Skip to content

feat: add top endpoint to supplies #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: add top endpoint to supplies #45

wants to merge 3 commits into from

Conversation

balsemao
Copy link

@balsemao balsemao commented May 10, 2024 •
edited
Loading

Adicionado o endpoint /supplies/top com os parâmetros page e perPage.

curl 'localhost:4000/supplies/top?perPage=3&page=1'
{
  "statusCode": 200,
  "message": "Successfully get top supplies",
  "data": [
    {
      "name": "1 Notebook pode ser usado",
      "amount": 1
    },
    {
      "name": "Aparelho de barbear",
      "amount": 1
    },
    {
      "name": "Turnos de manhã",
      "amount": 1
    }
  ]
}

Em seguida atualizo com o filtro por abrigo.

AndersonCRocha
AndersonCRocha reviewed May 10, 2024
View reviewed changes
src/supply/supply.controller.ts Outdated
@Get('top')
async top(@Query('limit') limit: number = 10, @Query('skip') skip: number) {
try {
if (limit && typeof limit === 'string') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

é só usar o pipe ParseIntPipe

see: https://docs.nestjs.com/pipes#built-in-pipes

Copy link
Author

@balsemao balsemao May 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa, ajustado!

AndersonCRocha
AndersonCRocha reviewed May 10, 2024
View reviewed changes
@balsemao
Copy link
Author

Vou precisar mudar a abordagem. O Prisma, ao que tudo indica, não suporta JOIN no aggregate(). Desta forma, vou precisar incluir a query bruta de SQL.

@balsemao
Copy link
Author

@AndersonCRocha atualizei o PR utilizando uma nova query para que sejam contados os top N items por abrigo. Incluído também o filtro por abrigo (shelterId, opcional)

@pastorini-cesar
Copy link

@balsemao Veja o que consegue usar desse commit cesarpastorini@e74abe5

@balsemao
Copy link
Author

@balsemao Veja o que consegue usar desse commit cesarpastorini@e74abe5

Valeu! Eu acabei fazendo o CAST para int na própria query e resolveu o problema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@AndersonCRocha AndersonCRocha AndersonCRocha left review comments

@fontolangustavo fontolangustavo fontolangustavo approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
waiting-business-requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@balsemao @pastorini-cesar @fontolangustavo @AndersonCRocha @filipepacheco